[all-commits] [llvm/llvm-project] d4569d: [AMDGPU] Let LowerModuleLDS run twice on the same ...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Mon Mar 11 01:20:24 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4569d42b5cb8ba076f0115d3d21d89f68e6ce9d
      https://github.com/llvm/llvm-project/commit/d4569d42b5cb8ba076f0115d3d21d89f68e6ce9d
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    R llvm/test/CodeGen/AMDGPU/lds-reject-absolute-addresses.ll
    A llvm/test/CodeGen/AMDGPU/lds-reject-mixed-absolute-addresses.ll
    A llvm/test/CodeGen/AMDGPU/lds-run-twice-absolute-md.ll
    A llvm/test/CodeGen/AMDGPU/lds-run-twice.ll

  Log Message:
  -----------
  [AMDGPU] Let LowerModuleLDS run twice on the same module (#81729)

If all variables in the module are absolute, this means we're running
the pass again on an already lowered module, and that works.
If none of them are absolute, lowering can proceed as usual.
Only diagnose cases where we have a mix of absolute/non-absolute GVs,
which means we added LDS GVs after lowering, which is broken.

See #81491
Split from #75333



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list