[all-commits] [llvm/llvm-project] 448419: update_test_checks: precommit a test case

[Nicolai Hähnle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 448419007e1bb8a9e2edfe2c1c87fef6d104442a
      https://github.com/llvm/llvm-project/commit/448419007e1bb8a9e2edfe2c1c87fef6d104442a
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values2.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values2.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values3.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values3.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values4.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values4.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/stable_ir_values.test
    A llvm/test/tools/UpdateTestChecks/update_test_checks/stable_ir_values2.test
    A llvm/test/tools/UpdateTestChecks/update_test_checks/stable_ir_values3.test
    A llvm/test/tools/UpdateTestChecks/update_test_checks/stable_ir_values4.test

  Log Message:
  -----------
  update_test_checks: precommit a test case

The test case demonstrates how meta variables are needlessly renamed,
making diffs harder to read.


  Commit: fc1e5f978561d6357083f9b5bc981e52d93374b3
      https://github.com/llvm/llvm-project/commit/fc1e5f978561d6357083f9b5bc981e52d93374b3
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  update_test_checks: simplify is_local_def_ir_value

The match argument is unused.


  Commit: 5747f9d3e9f3a49c27984b9341e123b9ca82e741
      https://github.com/llvm/llvm-project/commit/5747f9d3e9f3a49c27984b9341e123b9ca82e741
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  update_test_checks: simplify get_ir_regex

The match argument isn't used.


  Commit: fb02f9ac84a6151e41aba8f7391edd132a9aaf14
      https://github.com/llvm/llvm-project/commit/fb02f9ac84a6151e41aba8f7391edd132a9aaf14
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values.ll.expected.reset
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values2.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values3.ll
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values3.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/stable_ir_values4.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/stable_ir_values.test
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  update_test_checks: keep meta variables stable by default

Prior to this change, running UTC on larger tests, especially tests
with unnamed IR values, often resulted in a spuriously large diff
because e.g. TMPnn variables in the CHECK lines were renumbered. This
change attempts to reduce the diff by keeping those variable names the
same.

There are cases in which this "drift" of variable names can end up being
more confusing. The old behavior can be re-enabled with the
--reset-variable-names command line argument.

The improvement may not be immediately apparent in the diff of this change.
The point is that the diff of stable_ir_values.ll against
stable_ir_values.ll.expected after this change is smaller.

Ideally, we'd also keep meta variables for "global" objects stable, e.g.
for attributes (#nn) and metadata (!nn). However, that would require a
much more substantial refactoring of how we generate check lines, so I
left it for future work.


Compare: https://github.com/llvm/llvm-project/compare/a4703e5bccc6...fb02f9ac84a6

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications