[all-commits] [llvm/llvm-project] ddaf04: [mlir][Transforms][NFC] Make signature conversion ...

Matthias Springer via All-commits all-commits at lists.llvm.org
Thu Mar 7 17:06:46 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ddaf040ea924b1bdd4e093f583018c262da3cc7f
      https://github.com/llvm/llvm-project/commit/ddaf040ea924b1bdd4e093f583018c262da3cc7f
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Make signature conversion more efficient (#83922)

During block signature conversion, a new block is inserted and ops are
moved from the old block to the new block. This commit changes the
implementation such that ops are moved in bulk (`splice`) instead of
one-by-one; that's what `splitBlock` is doing.

This also makes it possible to pass the new block argument types
directly to `createBlock` instead of using `addArgument` (which bypasses
the rewriter). This doesn't change anything from a technical point of
view (there is no rewriter API for adding arguments at the moment), but
the implementation reads a bit nicer.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list