[all-commits] [llvm/llvm-project] 2e2592: [compiler-rt] Only query llvm-config in the orc tests

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e25926b50183cb3d819e85ef7bdf00001027859
      https://github.com/llvm/llvm-project/commit/2e25926b50183cb3d819e85ef7bdf00001027859
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M compiler-rt/test/lit.common.cfg.py
    M compiler-rt/test/orc/lit.cfg.py

  Log Message:
  -----------
  [compiler-rt] Only query llvm-config in the orc tests

This check for assertions is only used inside the test/orc directory, but
doing it in the top level lit config means all testsuites depend on
llvm-config being present. This is not necessarily needed e.g. when
testing just the builtins. While touching this code, simplify it a bit
by using subprocess.check_output() instead of Popen() and use a string
comparison instead of a regex match.

Reviewed By: lhames

Pull Request: https://github.com/llvm/llvm-project/pull/83705



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications