[all-commits] [llvm/llvm-project] 3ecd38: [libomptarget] Build plugins-nextgen for SystemZ (...

[Ulrich Weigand via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3ecd38c8e1d34b1e4639a1de9f0cb56c7957cbd2
      https://github.com/llvm/llvm-project/commit/3ecd38c8e1d34b1e4639a1de9f0cb56c7957cbd2
  Author: Ulrich Weigand <ulrich.weigand at de.ibm.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
    M llvm/lib/Frontend/OpenMP/OMPContext.cpp
    M openmp/libomptarget/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/aarch64/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/ppc64/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/ppc64le/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/s390x/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/x86_64/CMakeLists.txt
    M openmp/libomptarget/src/CMakeLists.txt
    M openmp/libomptarget/test/api/omp_dynamic_shared_memory.c
    M openmp/libomptarget/test/jit/empty_kernel_lvl1.c
    M openmp/libomptarget/test/jit/empty_kernel_lvl2.c
    M openmp/libomptarget/test/jit/type_punning.c
    M openmp/libomptarget/test/mapping/auto_zero_copy.cpp
    M openmp/libomptarget/test/mapping/auto_zero_copy_globals.cpp
    M openmp/libomptarget/test/offloading/barrier_fence.c
    M openmp/libomptarget/test/offloading/bug49334.cpp
    M openmp/libomptarget/test/offloading/default_thread_limit.c
    M openmp/libomptarget/test/offloading/ompx_bare.c
    M openmp/libomptarget/test/offloading/ompx_coords.c
    M openmp/libomptarget/test/offloading/ompx_saxpy_mixed.c
    M openmp/libomptarget/test/offloading/parallel_target_teams_reduction.cpp
    M openmp/libomptarget/test/offloading/small_trip_count.c
    M openmp/libomptarget/test/offloading/small_trip_count_thread_limit.cpp
    M openmp/libomptarget/test/offloading/spmdization.c
    M openmp/libomptarget/test/offloading/target_critical_region.cpp
    M openmp/libomptarget/test/offloading/thread_limit.c
    M openmp/libomptarget/test/ompt/target_memcpy.c
    M openmp/libomptarget/test/ompt/target_memcpy_emi.c
    M openmp/libomptarget/test/ompt/veccopy.c
    M openmp/libomptarget/test/ompt/veccopy_data.c
    M openmp/libomptarget/test/ompt/veccopy_disallow_both.c
    M openmp/libomptarget/test/ompt/veccopy_emi.c
    M openmp/libomptarget/test/ompt/veccopy_emi_map.c
    M openmp/libomptarget/test/ompt/veccopy_map.c

  Log Message:
  -----------
  [libomptarget] Build plugins-nextgen for SystemZ (#83978)

The plugin was not getting built as the build_generic_elf64 macro
assumes the LLVM triple processor name matches the CMake processor name,
which is unfortunately not the case for SystemZ.

Fix this by providing two separate arguments instead.

Actually building the plugin exposed a number of other issues causing
various test failures. Specifically, I've had to add the SystemZ target
to
- CompilerInvocation::ParseLangArgs
- linkDevice in ClangLinuxWrapper.cpp
- OMPContext::OMPContext (to set the device_kind_cpu trait)
- LIBOMPTARGET_ALL_TARGETS in libomptarget/CMakeLists.txt
- a check_plugin_target call in libomptarget/src/CMakeLists.txt

Finally, I've had to set a number of test cases to UNSUPPORTED on
s390x-ibm-linux-gnu; all these tests were already marked as UNSUPPORTED
for x86_64-pc-linux-gnu and aarch64-unknown-linux-gnu and are failing on
s390x for what seem to be the same reason.

In addition, this also requires support for BE ELF files in
plugins-nextgen: https://github.com/llvm/llvm-project/pull/83976



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications