[all-commits] [llvm/llvm-project] 04bbbb: Skip TestAddressMasks API tests on 32-bit arm

Jason Molenda via All-commits all-commits at lists.llvm.org
Wed Mar 6 10:58:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04bbbba271ebe4c2421f34a4fbf34c328df9f111
      https://github.com/llvm/llvm-project/commit/04bbbba271ebe4c2421f34a4fbf34c328df9f111
  Author: Jason Molenda <jason at molenda.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M lldb/test/API/python_api/process/address-masks/TestAddressMasks.py

  Log Message:
  -----------
  Skip TestAddressMasks API tests on 32-bit arm

TestAddressMasks failed on the lldb-arm-buntu bot with the
Code address mask test,

        mask = process.GetAddressMask(lldb.eAddressMaskTypeAny)
        process.SetAddressMask(lldb.eAddressMaskTypeCode, mask | 0x3)
        self.assertEqual(
            0x000002950001F694,
            process.FixAddress(0x00265E950001F697, lldb.eAddressMaskTypeCode),
        )

The API returned 0x000002950001f694 instead of the expected
0x00265e950001f696.  The low bits differ because ABISysV_arm hardcodes
the Code address mask to clear the 0th bit, it doesn't use the
Process code mask.  I didn't debug why some of the high bytes were
dropped.  The address mask APIs are only important on 64-bit targets,
where many of the bits are not used for addressing and are used for
metadata instead, so I'm going to skip these tests on 32-bit arm
instead of debugging.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list