[all-commits] [llvm/llvm-project] a6ee0a: [llvm-mca][AMDGPU] Retire instructions that have i...

[Michael Maitland via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6ee0adb724a3f1705fc54937e734ffc2a032096
      https://github.com/llvm/llvm-project/commit/a6ee0adb724a3f1705fc54937e734ffc2a032096
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M llvm/lib/MCA/Stages/InOrderIssueStage.cpp
    A llvm/test/tools/llvm-mca/AMDGPU/carried-over.s

  Log Message:
  -----------
  [llvm-mca][AMDGPU] Retire instructions that have issue carry over correctly (#83881)

https://github.com/llvm/llvm-project/issues/83775 shows llvm-mca hits
sanitizer error in cycleEnd. There was an instruction that takes
multiple cycles to issue and is finished executing directly after issue.
Prior to this patch, the instruction is retired on the first issue
cycle, despite taking multiple cycles to issue.

To fix this, if an instruction takes multiple cycles to issue and is
done executing after issue, let updateCarriedOver retire the instruction
when it is fully issued.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications