[all-commits] [llvm/llvm-project] 58d880: [RISCV] Always use signed APSInt in getExactIntege...

Craig Topper via All-commits all-commits at lists.llvm.org
Tue Mar 5 14:36:49 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58d8805ff9f0a9947ac122b463c00d6c0656eae6
      https://github.com/llvm/llvm-project/commit/58d8805ff9f0a9947ac122b463c00d6c0656eae6
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-03-05 (Tue, 05 Mar 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/test/CodeGen/RISCV/rvv/vle_vid-vfcvt.ll

  Log Message:
  -----------
  [RISCV] Always use signed APSInt in getExactInteger. (#84070)

We were setting based on whether the FP value is positive/negative, but
we really want to know whether the resulting integer will be treated as
a signed or unsigned value. Since we use SINT_TO_FP to convert the
integer to FP, we should always used signed here.

Without this we convert +2147483648.0 to an integer 0x80000000 and
convert it using sint_to_fp which produces -2147483648.0.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list