[all-commits] [llvm/llvm-project] d01671: [bzl] Remove obsolete `output_to_genfiles = True` ...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Mon Mar 4 21:00:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d016712b2cbeecf13c0d558c7c8932fd66e14847
      https://github.com/llvm/llvm-project/commit/d016712b2cbeecf13c0d558c7c8932fd66e14847
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl
    M utils/bazel/llvm-project-overlay/mlir/tblgen.bzl

  Log Message:
  -----------
  [bzl] Remove obsolete `output_to_genfiles = True` (#83944)

The [bazel docs](https://bazel.build/rules/lib/globals/bzl#rule)
discourage setting this. The comments about being necessary for headers
or genrules seem to be obsolete, at least for the LLVM tree itself.

The effect of this is that generated files will go to `bazel-bin`
instead of `bazel-genfiles`.

One external use was fixed here:
https://github.com/google/jax/commit/32bb3b06132b4256cd8674fb98bce057dc968610.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list