[all-commits] [llvm/llvm-project] 4ea3fc: [mlir][Transforms][NFC] Make signature conversion ...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/block_signature_efficiency
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ea3fc3f686937d2f3e2f23c34197343aae2c0be
      https://github.com/llvm/llvm-project/commit/4ea3fc3f686937d2f3e2f23c34197343aae2c0be
  Author: Matthias Springer <springerm at google.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Make signature conversion more efficient

During block signature conversion, a new block is inserted and ops are moved from the old block to the new block. This commit changes the implementation such that ops are moved in bulk (`splice`) instead of one-by-one; that's what `splitBlock` is doing.

This also makes it possible to pass the new block argument types directly to `createBlock` instead of using `addArgument` (which bypasses the rewriter). This doesn't change anything from a technical point of view (there is no rewriter API for adding arguments at the moment), but the implementation reads a bit nicer.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications