[all-commits] [llvm/llvm-project] 43b7df: Revert "[SROA] Unfold gep of index phi (#83087)"

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Feb 28 15:56:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43b7dfcc1dbdf904b1c507e03e5c34d527b5a344
      https://github.com/llvm/llvm-project/commit/43b7dfcc1dbdf904b1c507e03e5c34d527b5a344
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/test/Transforms/SROA/phi-and-select.ll
    M llvm/test/Transforms/SROA/phi-gep.ll

  Log Message:
  -----------
  Revert "[SROA] Unfold gep of index phi (#83087)"

This reverts commit 2eb63982e88b9ed8336158d35884b1a1d04a0f78.

This caused verifier error
```
Instruction does not dominate all uses!
```
for some projects using Halide.
The verifier error happens inside `Halide::Internal::CodeGen_LLVM::optimize_module`
and looks like a genuine SROA issue.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list