[all-commits] [llvm/llvm-project] d3173f: [lldb] Remove -d(ebug) mode from the lldb driver (...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Feb 28 15:24:08 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3173f4ab61c17337908eb7df3f1c515ddcd428c
      https://github.com/llvm/llvm-project/commit/d3173f4ab61c17337908eb7df3f1c515ddcd428c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M lldb/test/Shell/Driver/TestHelp.test
    M lldb/tools/driver/Driver.cpp
    M lldb/tools/driver/Driver.h

  Log Message:
  -----------
  [lldb] Remove -d(ebug) mode from the lldb driver (#83330)

The -d(ebug) option broke 5 years ago when I migrated the driver to
libOption. Since then, we were never check if the option is set. We were
incorrectly toggling the internal variable (m_debug_mode) based on
OPT_no_use_colors instead.

Given that the functionality doesn't seem particularly useful and nobody
noticed it has been broken for 5 years, I'm just removing the flag.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list