[all-commits] [llvm/llvm-project] 2cacc7: [lldb-dap] Deduplicate watchpoints starting at the...

[Zequan Wu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cacc7a61095577ff42177373d46c8cb8df0cb1f
      https://github.com/llvm/llvm-project/commit/2cacc7a61095577ff42177373d46c8cb8df0cb1f
  Author: Zequan Wu <zequanwu at google.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/databreakpoint/TestDAP_setDataBreakpoints.py
    M lldb/tools/lldb-dap/Watchpoint.cpp
    M lldb/tools/lldb-dap/Watchpoint.h
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb-dap] Deduplicate watchpoints starting at the same address on SetDataBreakpointsRequest. (#83192)

If a SetDataBreakpointsRequest contains a list data breakpoints which
have duplicate starting addresses, the current behaviour is returning
`{verified: true}` to both watchpoints with duplicated starting
addresses. This confuses the client and what actually happens in lldb is
the second one overwrite the first one.

This fixes it by letting the last watchpoint at given address have
`{verified: true}` and all previous watchpoints at the same address
should have `{verfied: false}` at response.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications