[all-commits] [llvm/llvm-project] e39e30: [mlir][llvm] Fix access group translation (#83257)

[Tobias Gysi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e39e30e95237bee53346acf16d197de8fdf4825e
      https://github.com/llvm/llvm-project/commit/e39e30e95237bee53346acf16d197de8fdf4825e
  Author: Tobias Gysi <tobias.gysi at nextsilicon.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/test/Target/LLVMIR/attribute-alias-scopes.mlir

  Log Message:
  -----------
  [mlir][llvm] Fix access group translation (#83257)

This commit fixes the translation of access group metadata to LLVM IR.
Previously, it did not use a temporary metadata node to model the
placeholder of the self-referencing access group nodes. This is
dangerous since, the translation may produce a metadata list with a null
entry that is later on changed changed with a self reference. At the
same time, for example the debug info translation may create the same
uniqued node, which after setting the self-reference the suddenly
references the access group metadata. The commit avoids such breakages.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications