[all-commits] [llvm/llvm-project] 9cce71: [mlir][Transforms][NFC] Remove `SplitBlockRewrite`

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/remove_split_block_rewrite
  Home:   https://github.com/llvm/llvm-project
  Commit: 9cce7198b463b710e3de6e7b7b7d101249911b80
      https://github.com/llvm/llvm-project/commit/9cce7198b463b710e3de6e7b7b7d101249911b80
  Author: Matthias Springer <springerm at google.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M mlir/include/mlir/IR/PatternMatch.h
    M mlir/include/mlir/Transforms/DialectConversion.h
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Remove `SplitBlockRewrite`

When splitting a block during a dialect conversion, a `SplitBlockRewrite` object is stored in the dialect conversion state. This commit removes `SplitBlockRewrite`. Instead, a combination of `CreateBlockRewrite` and multiple `MoveOperationRewrite` is used.

This change simplifies the internal state of the dialect conversion and is also needed to properly support listeners.

`RewriteBase::splitBlock` is now no longer virtual. All necessary information for committing/rolling back a split block rewrite can be deduced from `Listener::notifyBlockInserted` and `Listener::notifyOperationInserted` (which is also called when moving an operation).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications