[all-commits] [llvm/llvm-project] bcbce8: Revert "[HIP] fix host min/max in header (#82956)"

[Yaxun (Sam) Liu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bcbce807d76a30388b366d14051c5f80e9724dab
      https://github.com/llvm/llvm-project/commit/bcbce807d76a30388b366d14051c5f80e9724dab
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M clang/lib/Headers/__clang_hip_math.h

  Log Message:
  -----------
  Revert "[HIP] fix host min/max in header (#82956)"

This reverts commit 55783bd0f9cfc30aa93c718919dab5419d86a2c6.

Due to regressions in hipCUB.

hipCUB/hipcub/include/hipcub/backend/rocprim/device/device_spmv.hpp:142:33: error: call to 'min' is ambiguous

https://github.com/ROCm/hipCUB/blob/develop/hipcub/include/hipcub/backend/rocprim/device/device_spmv.hpp#L142

The ambuguity seems due to missing min(int, unsigned int).

Previously, there is only min(int, int). After the change,
there are min(int, int) and min(unsigned int, unsigned int),
therefore there is ambiguity.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications