[all-commits] [llvm/llvm-project] b0564f: LAA cannot vectorize lib calls like modf/modff

[Paschalis Mpeis via All-commits]

  Branch: refs/heads/users/paschalis-mpeis/laa-vectorize-modf
  Home:   https://github.com/llvm/llvm-project
  Commit: b0564fa66d474fd45326dae6429e5e592ec22a85
      https://github.com/llvm/llvm-project/commit/b0564fa66d474fd45326dae6429e5e592ec22a85
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    A clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c

  Log Message:
  -----------
  LAA cannot vectorize lib calls like modf/modff

Functions like modf/modff are math lib calls that set memory write-only
attribute. Given that a target has vectorized mappings, LAA should allow
vectorization.


  Commit: a0c54a3aabd00011f28fdb40661f4c002fbfb5d9
      https://github.com/llvm/llvm-project/commit/a0c54a3aabd00011f28fdb40661f4c002fbfb5d9
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  [LV][LAA] Vectorize math lib calls with mem write-only attribute

Teach LAA to consider safe specific math lib calls which are known to
have set the memory write-only attribute. Those attributes are set to
calls by inferNonMandatoryLibFuncAttrs, in BuildLibCalls.cpp, and the
current ones are modf/modff and frexp/frexpf.

This happens only when the calls are found through TLI to have
vectorized counterparts.


  Commit: 53a165c35f66cd81ec65b45ea9cea7e55c0e4742
      https://github.com/llvm/llvm-project/commit/53a165c35f66cd81ec65b45ea9cea7e55c0e4742
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  Add check for the 'memory(argmem: write)' attribute.


  Commit: 91d67cc44559d0eeb3318b72d697d70064d045dd
      https://github.com/llvm/llvm-project/commit/91d67cc44559d0eeb3318b72d697d70064d045dd
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  Addressing reviewers


  Commit: 2e3d0d6d643f4eab1882ea93f78bc9fe1c3c14af
      https://github.com/llvm/llvm-project/commit/2e3d0d6d643f4eab1882ea93f78bc9fe1c3c14af
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c

  Log Message:
  -----------
  Rebased and updated test after PR #80296


  Commit: 513ba7ad5ee6b61ddac14187f3376342e343c0d7
      https://github.com/llvm/llvm-project/commit/513ba7ad5ee6b61ddac14187f3376342e343c0d7
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    R clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp
    A llvm/test/Analysis/LoopAccessAnalysis/attr-mem-write-only.ll
    A llvm/test/Transforms/LoopVectorize/AArch64/veclib-function-calls-linear-ptrs.ll

  Log Message:
  -----------
  Added LAA and LV tests

Removed C test.
Code rebased on top of patch that enables mappings for modf/modff
(among others).


Compare: https://github.com/llvm/llvm-project/compare/2a385264b91c...513ba7ad5ee6

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications