[all-commits] [llvm/llvm-project] 04db60: [AMDGPU] Prevent hang in SIFoldOperands by caching...

choikwa via All-commits all-commits at lists.llvm.org
Tue Feb 27 07:14:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04db60d15069494f4effad7a1001965904b36e6f
      https://github.com/llvm/llvm-project/commit/04db60d15069494f4effad7a1001965904b36e6f
  Author: choikwa <5455710+choikwa at users.noreply.github.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
    A llvm/test/CodeGen/AMDGPU/si-fold-reg-sequence.mir

  Log Message:
  -----------
  [AMDGPU] Prevent hang in SIFoldOperands by caching uses (#82099)

foldOperands() for REG_SEQUENCE has recursion that can trigger an infinite loop
as the method can modify the operand order, which messes up the range-based
for loop. This patch fixes the issue by caching the uses for processing beforehand,
and then iterating over the cache rather using the instruction iterator.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list