[all-commits] [llvm/llvm-project] 1ecbab: [C++20] [Modules] Don't import non-inline function...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ecbab56dcbb78268c8d19af34a50591f90b12a0
      https://github.com/llvm/llvm-project/commit/1ecbab56dcbb78268c8d19af34a50591f90b12a0
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-02-18 (Sun, 18 Feb 2024)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGenCXX/module-funcs-from-imports.cppm

  Log Message:
  -----------
  [C++20] [Modules] Don't import non-inline function bodies even if it is marked as always_inline

Close https://github.com/llvm/llvm-project/issues/80949

Previously, I thought the always-inline function can be an exception to
enable optimizations as much as possible. However, it looks like it
breaks the ABI requirement we discussed later. So it looks better to not
import non-inline function bodies at all even if the function bodies are
marked as always_inline.

It doesn't produce regressions in some degree since the always_inline
still works in the same TU.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications