[all-commits] [llvm/llvm-project] bf93f4: [lldb] Fix and rename skipIfHostIncompatibleWithRe...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri Feb 16 07:59:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
      https://github.com/llvm/llvm-project/commit/bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/decorators.py
    M lldb/test/API/api/command-return-object/TestSBCommandReturnObject.py
    M lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
    M lldb/test/API/api/multiple-targets/TestMultipleTargets.py
    M lldb/test/API/api/multithreaded/TestMultithreaded.py
    M lldb/test/API/functionalities/plugins/command_plugin/TestPluginCommands.py

  Log Message:
  -----------
  [lldb] Fix and rename skipIfHostIncompatibleWithRemote

Fix and rename the broken and confusingly named decorator
skipIfHostIncompatibleWithRemote. The decorator is meant to skip test
which uses the inferior test build system (i.e. to build test inferiors)
to build host binaries (e.g. lldb drivers).

The decorator was broken on macOS, where the host and target platform
report macosx, but the decorator overwrote it with Darwin, resulting in
tests incorrectly being skipped.

The decorator was also missing on a handful of tests that use the
buildDriver helper, which this commit fixes as well.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list