[all-commits] [llvm/llvm-project] 9cf0c2: MipsAsmParser/O32: Don't add redundant $ to $-pref...

YunQiang Su via All-commits all-commits at lists.llvm.org
Thu Feb 15 22:14:41 PST 2024


  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 9cf0c2962fd26b6fc9a665b75732b44b1603e1ee
      https://github.com/llvm/llvm-project/commit/9cf0c2962fd26b6fc9a665b75732b44b1603e1ee
  Author: YunQiang Su <syq at debian.org>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
    M llvm/test/CodeGen/Mips/hf1_body.ll
    M llvm/test/MC/Mips/macro-la-pic.s

  Log Message:
  -----------
  MipsAsmParser/O32: Don't add redundant $ to $-prefixed symbol in the la macro (#80644)

When parsing the `la` macro, we add a duplicate `$` prefix in
`getOrCreateSymbol`,
leading to `error: Undefined temporary symbol $$yy` for code like:

```
xx:
	la	$2,$yy
$yy:
	nop
```

Remove the duplicate prefix.

In addition, recognize `.L`-prefixed symbols as local for O32.

See: #65020.

---------

Co-authored-by: Fangrui Song <i at maskray.me>
(cherry picked from commit c007fbb19879f9b597b47ae772c53e53cdc65f29)




More information about the All-commits mailing list