[all-commits] [llvm/llvm-project] c007fb: MipsAsmParser/O32: Don't add redundant $ to $-pref...
YunQiang Su via All-commits
all-commits at lists.llvm.org
Wed Feb 14 12:49:07 PST 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: c007fbb19879f9b597b47ae772c53e53cdc65f29
https://github.com/llvm/llvm-project/commit/c007fbb19879f9b597b47ae772c53e53cdc65f29
Author: YunQiang Su <syq at debian.org>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
M llvm/test/CodeGen/Mips/hf1_body.ll
M llvm/test/MC/Mips/macro-la-pic.s
Log Message:
-----------
MipsAsmParser/O32: Don't add redundant $ to $-prefixed symbol in the la macro (#80644)
When parsing the `la` macro, we add a duplicate `$` prefix in
`getOrCreateSymbol`,
leading to `error: Undefined temporary symbol $$yy` for code like:
```
xx:
la $2,$yy
$yy:
nop
```
Remove the duplicate prefix.
In addition, recognize `.L`-prefixed symbols as local for O32.
See: #65020.
---------
Co-authored-by: Fangrui Song <i at maskray.me>
More information about the All-commits
mailing list