[all-commits] [llvm/llvm-project] b2fb94: [mlir][flang][openmp] Rework wsloop reduction oper...

[Kiran Chandramohan via All-commits]

  Branch: refs/heads/users/davidtruby/wsreduction
  Home:   https://github.com/llvm/llvm-project
  Commit: b2fb948fe3ea1f4273aab271639b944e50d667b8
      https://github.com/llvm/llvm-project/commit/b2fb948fe3ea1f4273aab271639b944e50d667b8
  Author: David Truby <david at truby.dev>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M flang/lib/Lower/OpenMP.cpp
    M flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-add.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-iand.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-ieor.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-ior.f90
    R flang/test/Lower/OpenMP/FIR/wsloop-reduction-logical-and.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-logical-eqv.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-logical-neqv.f90
    R flang/test/Lower/OpenMP/FIR/wsloop-reduction-logical-or.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-max.f90
    M flang/test/Lower/OpenMP/FIR/wsloop-reduction-min.f90
    R flang/test/Lower/OpenMP/FIR/wsloop-reduction-mul.f90
    M flang/test/Lower/OpenMP/default-clause.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-add-hlfir.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-add.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-iand.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-ieor.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-ior.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-logical-and.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-logical-eqv.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-logical-neqv.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-logical-or.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-max-2.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-max-hlfir.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-max.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-min.f90
    M flang/test/Lower/OpenMP/wsloop-reduction-mul.f90
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
    M mlir/test/Dialect/OpenMP/invalid.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/test/Target/LLVMIR/openmp-reduction.mlir

  Log Message:
  -----------
  [mlir][flang][openmp] Rework wsloop reduction operations

This patch reworks the way that wsloop reduction operations function to better
match the expected semantics from the OpenMP specification, following the rework
of parallel reductions.

The new semantics create a private reduction variable as a block argument which
should be used normally for all operations on that variable in the region; this
private variable is then combined with the others into the shared variable. This
way no special omp.reduction operations are needed inside the region. These
block arguments follow the loop control block arguments.


  Commit: 110679e98cc6f35c84e26a124e11a6193650f55e
      https://github.com/llvm/llvm-project/commit/110679e98cc6f35c84e26a124e11a6193650f55e
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M mlir/lib/Conversion/SCFToOpenMP/SCFToOpenMP.cpp
    M mlir/test/Conversion/SCFToOpenMP/reductions.mlir

  Log Message:
  -----------
  [MLIR][SCF][OpenMP] Update reduction conversion


  Commit: 9a339938bb22c74205a8dd4ee32b62fe4a241d15
      https://github.com/llvm/llvm-project/commit/9a339938bb22c74205a8dd4ee32b62fe4a241d15
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Conversion/SCFToOpenMP/SCFToOpenMP.cpp

  Log Message:
  -----------
  [MLIR][OpenMP] Address review comments


  Commit: d7267919b7350cad5e4fdf3cb03aae366aefcc46
      https://github.com/llvm/llvm-project/commit/d7267919b7350cad5e4fdf3cb03aae366aefcc46
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M flang/lib/Lower/OpenMP.cpp

  Log Message:
  -----------
  [Flang][OpenMP] Rebase changes


  Commit: 0f80a6f406b11ff8f9eccaea46b0dd039219830b
      https://github.com/llvm/llvm-project/commit/0f80a6f406b11ff8f9eccaea46b0dd039219830b
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M flang/lib/Lower/OpenMP.cpp

  Log Message:
  -----------
  [Flang][OpenMP] Fix code-formatting issues


Compare: https://github.com/llvm/llvm-project/compare/b2fb948fe3ea%5E...0f80a6f406b1