[all-commits] [llvm/llvm-project] d58c12: [lldb-dap][NFC] Add Breakpoint struct to share com...

[Zequan Wu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d58c128bc42b8a9cc45516ba9fe9e6a3c322d7b3
      https://github.com/llvm/llvm-project/commit/d58c128bc42b8a9cc45516ba9fe9e6a3c322d7b3
  Author: Zequan Wu <zequanwu at google.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    A lldb/tools/lldb-dap/Breakpoint.cpp
    A lldb/tools/lldb-dap/Breakpoint.h
    M lldb/tools/lldb-dap/BreakpointBase.cpp
    M lldb/tools/lldb-dap/BreakpointBase.h
    M lldb/tools/lldb-dap/CMakeLists.txt
    M lldb/tools/lldb-dap/FunctionBreakpoint.cpp
    M lldb/tools/lldb-dap/FunctionBreakpoint.h
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/JSONUtils.h
    M lldb/tools/lldb-dap/SourceBreakpoint.cpp
    M lldb/tools/lldb-dap/SourceBreakpoint.h
    M lldb/tools/lldb-dap/lldb-dap.cpp
    M llvm/utils/gn/secondary/lldb/tools/lldb-dap/BUILD.gn

  Log Message:
  -----------
  [lldb-dap][NFC] Add Breakpoint struct to share common logic. (#80753)

This adds a layer between `SounceBreakpoint`/`FunctionBreakpoint` and
`BreakpointBase` to have better separation and encapsulation so we are
not directly operating on `SBBreakpoint`.

I basically moved the `SBBreakpoint` and the methods that requires it
from `BreakpointBase` to `Breakpoint`. This allows adding support for
data watchpoint easier by sharing the logic inside `BreakpointBase`.