[all-commits] [llvm/llvm-project] b56b3d: [Clang][Sema] Don't consider top-level cv-qualifie...

[Younan Zhang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b56b3d75b04cda762ac8e15b7ec6fa4f52a6735a
      https://github.com/llvm/llvm-project/commit/b56b3d75b04cda762ac8e15b7ec6fa4f52a6735a
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp

  Log Message:
  -----------
  [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (#81449)

This fixes a regression since
https://github.com/llvm/llvm-project/commit/340eac01f7dad6c24cee35dd35f2484098dd6b1a,
from which we compared function parameter types with cv-qualifiers taken
into account. However, as per [dcl.fct]/p5:

> After producing the list of parameter types, any top-level
cv-qualifiers modifying
> a parameter type are deleted when forming the function type.

Thus, I think we should use `hasSameUnqualifiedType` for type
comparison.

This fixes https://github.com/llvm/llvm-project/issues/75404.