[all-commits] [llvm/llvm-project] f7f947: [InstCombine] Remove some uninteresting FIXMEs (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Feb 12 01:36:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f7f947e6208cb65ab1a29c4573bf927f967b9d5d
      https://github.com/llvm/llvm-project/commit/f7f947e6208cb65ab1a29c4573bf927f967b9d5d
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp

  Log Message:
  -----------
  [InstCombine] Remove some uninteresting FIXMEs (NFC)

If there are two undef operands, the select would get folded away
entirely. One undef operand can occur if the other two operands
do not satisfy the poison implication check. However, I don't think
that handling this edge case is worthwhile in this fold. If we
wanted to handle this, it would be more natural to do so in the
simplifyValueKnownNonZero() fold (as this is actually the property
we would be exploiting -- this doesn't really have any relation
to taking the log2).




More information about the All-commits mailing list