[all-commits] [llvm/llvm-project] 4bf9fa: [libc++][modules] Guard missing header validation ...

Mark de Wever via All-commits all-commits at lists.llvm.org
Fri Feb 9 08:41:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4bf9fa5fb50497878edf8e277574ea9fb7d6bb7f
      https://github.com/llvm/llvm-project/commit/4bf9fa5fb50497878edf8e277574ea9fb7d6bb7f
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M libcxx/modules/std.compat.cppm.in
    M libcxx/modules/std.cppm.in
    M libcxx/utils/generate_libcxx_cppm_in.py

  Log Message:
  -----------
  [libc++][modules] Guard missing header validation on Windows. (#80478)

On Windows the libc++ test suite sees the MSVC STL headers and may
conclude these are libc++ headers when inspecting the name. Modules
guard against forgetting to export new headers. Finding MSVC STL's
headers gives false positives. Since the CI tests non-Windows platforms
too, the validation will be disabled on Windows.

Fixes: https://github.com/llvm/llvm-project/issues/79010

---------

Co-authored-by: Louis Dionne <ldionne.2 at gmail.com>




More information about the All-commits mailing list