[all-commits] [llvm/llvm-project] 4f423e: [libc++][test] Adds backdeployment shorthands. (#7...

Mark de Wever via All-commits all-commits at lists.llvm.org
Fri Feb 9 08:26:30 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f423e4989056316f9d807abb92c14b188490e30
      https://github.com/llvm/llvm-project/commit/4f423e4989056316f9d807abb92c14b188490e30
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libc++][test] Adds backdeployment shorthands. (#78204)

Some changes in libc++ affect the dylib. These changes are not present
on systems that use the system dylib. Currently that are the Apple
backdeployment targets. Figuring out which MacOS versions to target is
not trivial for non-Apple engineers. These shorthands make it easier to
select the proper feature make a test UNSUPPORTED or XFAIL.

During the design discussion with Louis we considered whether or not to
add preprocessor definitions to allow partial disabling of a test. This
would be useful when an existing feature is changed by modifying the
dylib. In the end we decided not to add this feature to avoid additional
complexity in the tests. Instead the test will be disabled for that
target.




More information about the All-commits mailing list