[all-commits] [llvm/llvm-project] b5a273: [Polly][DebugInfo] Use getStableDebugLoc to avoid ...
Stephen Tozer via All-commits
all-commits at lists.llvm.org
Fri Feb 9 04:03:11 PST 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: b5a273a1cfe6f509f8d2541e04d9186438f33348
https://github.com/llvm/llvm-project/commit/b5a273a1cfe6f509f8d2541e04d9186438f33348
Author: Stephen Tozer <stephen.tozer at sony.com>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M polly/lib/Analysis/ScopDetectionDiagnostic.cpp
M polly/lib/Support/ScopLocation.cpp
M polly/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll
M polly/test/ScopDetectionDiagnostics/loop_has_multiple_exits.ll
Log Message:
-----------
[Polly][DebugInfo] Use getStableDebugLoc to avoid intrinsic-dependent behaviour (#81246)
Polly currently uses `getDebugLoc` in a few places to produce diagnostic
output; this is correct when interacting with specific instructions, but
may be incorrect when dealing with instruction ranges if debug
intrinsics are included. As a general rule, the debug locations attached
to debug intrinsics may be misleading compared to the surrounding
instructions, and are not generally used for anything other than
determining variable scope info; the recommended approach is therefore
to use `getStableDebugLoc` instead, which skips over debug intrinsics.
This is necessary to fix test failures that occur when enabling
non-instruction debug info, which removes debug intrinsics from basic
blocks and thus alters the diagnostic output of Polly (despite causing
no functional change).
More information about the All-commits
mailing list