[all-commits] [llvm/llvm-project] 74fc16: [lldb] Expand background symbol download (#80890)

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74fc16aaaa227b84e22706d2c5e376287f560b9e
      https://github.com/llvm/llvm-project/commit/74fc16aaaa227b84e22706d2c5e376287f560b9e
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M lldb/include/lldb/Core/ModuleList.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/source/Core/CoreProperties.td
    M lldb/source/Core/ModuleList.cpp
    M lldb/source/Host/common/Host.cpp
    M lldb/source/Symbol/SymbolLocator.cpp

  Log Message:
  -----------
  [lldb] Expand background symbol download (#80890)

LLDB has a setting (symbols.enable-background-lookup) that calls
dsymForUUID on a background thread for images as they appear in the
current backtrace. Originally, the laziness of only looking up symbols
for images in the backtrace only existed to bring the number of
dsymForUUID calls down to a manageable number.

Users have requesting the same functionality but blocking. This gives
them the same user experience as enabling dsymForUUID globally, but
without the massive upfront cost of having to download all the images,
the majority of which they'll likely not need.

This patch renames the setting to have a more generic name
(symbols.auto-download) and changes its values from a boolean to an
enum. Users can now specify "off", "background" and "foreground". The
default remains "off" although I'll probably change that in the near
future.