[all-commits] [llvm/llvm-project] 13c14a: Revert "[DebugInfo][RemoveDIs] Turn on non-instrin...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 13c14ad42c65e154dc079332dd5dd58e8925d26c
      https://github.com/llvm/llvm-project/commit/13c14ad42c65e154dc079332dd5dd58e8925d26c
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M llvm/lib/IR/BasicBlock.cpp

  Log Message:
  -----------
  Revert "[DebugInfo][RemoveDIs] Turn on non-instrinsic debug-info by default"

This reverts commit bdde5f9bea75e897bcc31a95b9c3376988c211cc.

Two situations that are tripping a few buildbots:

  https://lab.llvm.org/buildbot/#/builders/205/builds/25126

Here, polly is currently presenting a DebugLoc attached to a debugging
intrinsic as a "true" source location in a user report, something that's
unreliable.

  https://lab.llvm.org/buildbot/#/builders/184/builds/10242

These HWAsan failures are probably (97% confidence) because in
StackInfoBuilder::visit we're not observing DPValues attached to lifetime
intrinsics because they're delt with higher up the function.

But it's late-o'clock here, so revert for now.