[all-commits] [llvm/llvm-project] 8ea7f1: [BOLT][NFCI] Keep instruction annotations (#80382)

Maksim Panchenko via All-commits all-commits at lists.llvm.org
Tue Feb 6 20:00:06 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ea7f1d20ad8ab8c381800eefda948d85c6860cc
      https://github.com/llvm/llvm-project/commit/8ea7f1d20ad8ab8c381800eefda948d85c6860cc
  Author: Maksim Panchenko <maks at fb.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M bolt/lib/Passes/BinaryPasses.cpp

  Log Message:
  -----------
  [BOLT][NFCI] Keep instruction annotations (#80382)

We used to delete most instruction annotations before code emission. It
was done to release memory taken by annotations and to reduce overall
memory consumption. However, since the implementation of annotations has
moved to using existing instruction operands, the memory overhead
associated with them has reduced drastically. I measured that savings
are less than 0.5% on large binaries and processing time is just
slightly reduced if we keep them. Additionally, I plan to use
annotations in pre-emission passes for the Linux kernel rewriter.




More information about the All-commits mailing list