[all-commits] [llvm/llvm-project] c75c05: [analyzer] Support interestingness in ArrayBoundV2

[NagyDonat via All-commits]

  Branch: refs/reviewable/pr78315/r1
  Home:   https://github.com/llvm/llvm-project
  Commit: c75c05c6e894a46797913c5bdccb240cbcc01ae9
      https://github.com/llvm/llvm-project/commit/c75c05c6e894a46797913c5bdccb240cbcc01ae9
  Author: Donát Nagy <donat.nagy at ericsson.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
    M clang/test/Analysis/out-of-bounds-diagnostics.c
    A clang/test/Analysis/out-of-bounds-notes.c

  Log Message:
  -----------
  [analyzer] Support interestingness in ArrayBoundV2

This commit improves alpha.security.ArrayBoundV2 in two connected areas:
(1) It calls `markInteresting()` on the symbolic values that are
responsible for the out of bounds access.
(2) Its index-is-in-bounds assumptions are reported in note tags if they
provide information about the value of an interesting symbol.

This commit is limited to "display" changes: it introduces new
diagnostic pieces (potentially to bugs found by other checkers), but the
ArrayBoundV2 will make the same assumptions and detect the same bugs
before and after this change.

As a minor unrelated change, this commit also updates/removes some very
old comments which became obsolate due to my previous changes.