[all-commits] [llvm/llvm-project] cca496: [FastISel][X86] Use getTypeForExtReturn in GetRetu...

Craig Topper via All-commits all-commits at lists.llvm.org
Tue Feb 6 09:38:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cca49663a56d90f6773f140269940d606aa61430
      https://github.com/llvm/llvm-project/commit/cca49663a56d90f6773f140269940d606aa61430
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
    M llvm/lib/CodeGen/TargetLoweringBase.cpp
    M llvm/lib/Target/X86/X86FastISel.cpp
    M llvm/test/CodeGen/X86/avx512-intrinsics-fast-isel.ll
    M llvm/test/CodeGen/X86/avx512bwvl-intrinsics-fast-isel.ll
    M llvm/test/CodeGen/X86/avx512vl-intrinsics-fast-isel.ll
    M llvm/test/CodeGen/X86/fast-isel-fcmp.ll
    M llvm/test/CodeGen/X86/fast-isel-ret-ext.ll
    M llvm/test/CodeGen/X86/keylocker-intrinsics-fast-isel.ll
    M llvm/test/CodeGen/X86/xaluo.ll
    M llvm/test/CodeGen/X86/xmulo.ll
    M llvm/test/DebugInfo/X86/convert-debugloc.ll

  Log Message:
  -----------
  [FastISel][X86] Use getTypeForExtReturn in GetReturnInfo. (#80803)

The comment and code here seems to match getTypeForExtReturn. The
history shows that at the time this code was added, similar code existed
in SelectionDAGBuilder. SelectionDAGBuiler code has since been
refactored into getTypeForExtReturn.

This patch makes FastISel match SelectionDAGBuilder.

The test changes are because X86 has customization of
getTypeForExtReturn. So now we only extend returns to i8.

Stumbled onto this difference by accident.




More information about the All-commits mailing list