[all-commits] [llvm/llvm-project] 7d055a: [mlir][Symbol] Add verification that symbol's pare...

[Joshua Cao via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d055af14b7dd7e782b87fb883205eda65e8bd44
      https://github.com/llvm/llvm-project/commit/7d055af14b7dd7e782b87fb883205eda65e8bd44
  Author: Joshua Cao <cao.joshua at yahoo.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M mlir/include/mlir/IR/SymbolInterfaces.td
    M mlir/test/Dialect/LLVMIR/global.mlir
    M mlir/test/Dialect/Linalg/transform-op-replace.mlir
    M mlir/test/Dialect/Transform/ops-invalid.mlir
    M mlir/test/IR/invalid-func-op.mlir
    M mlir/test/IR/region.mlir
    M mlir/test/IR/traits.mlir
    M mlir/test/Transforms/canonicalize-dce.mlir
    M mlir/test/Transforms/canonicalize.mlir
    M mlir/test/Transforms/constant-fold.mlir
    M mlir/test/Transforms/cse.mlir
    M mlir/test/Transforms/test-legalizer-full.mlir
    M mlir/test/python/ir/value.py

  Log Message:
  -----------
  [mlir][Symbol] Add verification that symbol's parent is a SymbolTable (#80590)

Following the discussion in
https://discourse.llvm.org/t/symboltable-and-symbol-parent-child-relationship/75446,
we should enforce that a symbol's immediate parent is a symbol table.

I changed some tests to pass the verification. In most cases, we can
wrap the func with a module, change the func to another op with regions
i.e. scf.if, or change the expected error message.

---------

Co-authored-by: Mehdi Amini <joker.eph at gmail.com>