[all-commits] [llvm/llvm-project] a7bc9c: [Clang][Sema] Fix regression due to missing ambigu...

Shafik Yaghmour via All-commits all-commits at lists.llvm.org
Mon Feb 5 14:40:19 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de
      https://github.com/llvm/llvm-project/commit/a7bc9cb6ffa91ff0ebabc45c0c7263c7c2c3a4de
  Author: Shafik Yaghmour <shafik.yaghmour at intel.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M clang/include/clang/Sema/Lookup.h
    M clang/test/CXX/class.derived/class.member.lookup/p11.cpp

  Log Message:
  -----------
  [Clang][Sema] Fix regression due to missing ambiguity check before attempting access check. (#80730)

Previously when fixing ambiguous lookup diagnostics in
cc1b6668c57170cd440d321037ced89d6a61a9cb The change refactored
`LookupResult` to split out diagnosing access and ambiguous lookups. The
call to `getSema().CheckLookupAccess(...)` should have guarded by a
check for isAmbiguous(). This change adds that guard.

Fixes: https://github.com/llvm/llvm-project/issues/80435




More information about the All-commits mailing list