[all-commits] [llvm/llvm-project] 984fe4: [libc++] Rename __bit_reference template parameter...

[Dimitry Andric via All-commits]

  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 984fe4054a4e67ed3a781e15a4269a2a89b5f424
      https://github.com/llvm/llvm-project/commit/984fe4054a4e67ed3a781e15a4269a2a89b5f424
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M libcxx/include/__bit_reference

  Log Message:
  -----------
  [libc++] Rename __bit_reference template parameter to avoid conflict (#80661)

As of 4d20cfcf4eb08217ed37c4d4c38dc395d7a66d26, `__bit_reference`
contains a template `__fill_n` with a bool `_FillValue` parameter.

Unfortunately there is a relatively widely used piece of scientific
software called NetCDF, which exposes a (C) macro `_FillValue` in its
public headers.

When building the NetCDF C++ bindings, this quickly leads to compilation
errors when the macro interferes with the template in `__bit_reference`.

Rename the parameter to `_FillVal` to avoid the conflict.

(cherry picked from commit 1ec252298925de50b27930c557ba9de3cc397afe)