[all-commits] [llvm/llvm-project] a792cb: [mlir][IR] Do not trigger `notifyOperationInserted...

Matthias Springer via All-commits all-commits at lists.llvm.org
Fri Feb 2 00:50:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a792cb6e3e03aff22dabb6cc94db68d15d953a55
      https://github.com/llvm/llvm-project/commit/a792cb6e3e03aff22dabb6cc94db68d15d953a55
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M mlir/include/mlir/IR/Builders.h
    M mlir/lib/IR/Builders.cpp

  Log Message:
  -----------
  [mlir][IR] Do not trigger `notifyOperationInserted` for unlinked ops (#80278)

This commit changes `OpBuilder::create` and `OpBuilder::createOrFold`
such that `notifyOperationInserted` is no longer triggered if no
insertion point is set. In such a case, an unlinked operation is created
but not inserted, so `notifyOperationInserted` should not be triggered.

Note: Inserting another op into a block that belongs to an unlinked op
(e.g., by the builder of the unlinked op) will trigger a notification.




More information about the All-commits mailing list