[all-commits] [llvm/llvm-project] 7bd920: [NFC] [clang] add tests for merging of UsingShadow...

Matheus Izvekov via All-commits all-commits at lists.llvm.org
Thu Feb 1 21:30:24 PST 2024


  Branch: refs/heads/users/mizvekov/bug/clang-merge-usingshadowdecl
  Home:   https://github.com/llvm/llvm-project
  Commit: 7bd920a14240c85442467706236e0644f320aa5c
      https://github.com/llvm/llvm-project/commit/7bd920a14240c85442467706236e0644f320aa5c
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    A clang/test/Modules/GH80252.cppm
    A clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [NFC] [clang] add tests for merging of UsingShadowDecl


  Commit: db966f66a148ab5b5ba26250cbf0dab6be5a2c29
      https://github.com/llvm/llvm-project/commit/db966f66a148ab5b5ba26250cbf0dab6be5a2c29
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/ASTContext.cpp
    M clang/test/Modules/GH80252.cppm
    M clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [clang] fix merging of UsingShadowDecl

Previously, when deciding if two UsingShadowDecls where mergeable,
we would incorrectly only look for both pointing to the exact redecla
ration, whereas the correct thing is to look for declarations to the
same entity.

This problem has existed as far back as 2013, introduced in commit
fd8634a09de71.

This problem could manifest itself as ODR check false positives
when importing modules.

Fixes: #80252


Compare: https://github.com/llvm/llvm-project/compare/1e6827281750...db966f66a148


More information about the All-commits mailing list