[all-commits] [llvm/llvm-project] f7340f: [NFC] [clang] add tests for merging of UsingShadow...

Matheus Izvekov via All-commits all-commits at lists.llvm.org
Thu Feb 1 19:48:20 PST 2024


  Branch: refs/heads/users/mizvekov/bug/clang-merge-usingshadowdecl
  Home:   https://github.com/llvm/llvm-project
  Commit: f7340f3781a3e3094169c970aadb9b69414543f5
      https://github.com/llvm/llvm-project/commit/f7340f3781a3e3094169c970aadb9b69414543f5
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    A clang/test/Modules/GH80252.cppm
    A clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [NFC] [clang] add tests for merging of UsingShadowDecl


  Commit: 1e6827281750a7fe33b8fa1bc66524b6f52d9080
      https://github.com/llvm/llvm-project/commit/1e6827281750a7fe33b8fa1bc66524b6f52d9080
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/ASTContext.cpp
    M clang/test/Modules/GH80252.cppm
    M clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [clang] fix merging of UsingShadowDecl

Previously, when deciding if two UsingShadowDecls where mergeable,
we would incorrectly only look for both pointing to the exact redecla
ration, whereas the correct thing is to look for declarations to the
same entity.

This problem has existed as far back as 2013, introduced in commit
fd8634a09de71.

This problem could manifest itself as ODR check false positives
when importing modules.

Fixes: #80252


Compare: https://github.com/llvm/llvm-project/compare/f2e37f079cec...1e6827281750


More information about the All-commits mailing list