[all-commits] [llvm/llvm-project] eaa3d5: Done iterating with arm-ubuntu bot, I see the prob...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eaa3d5e26665ca85d488e9194b9fbe304db6fa21
      https://github.com/llvm/llvm-project/commit/eaa3d5e26665ca85d488e9194b9fbe304db6fa21
  Author: Jason Molenda <jason at molenda.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M lldb/unittests/Breakpoint/WatchpointAlgorithmsTests.cpp

  Log Message:
  -----------
  Done iterating with arm-ubuntu bot, I see the problem test.
Go back to the original form of this file before I add temp
workaround.


  Commit: 90e68086d8fdbfb32dfc7e7e3498f44365274ce8
      https://github.com/llvm/llvm-project/commit/90e68086d8fdbfb32dfc7e7e3498f44365274ce8
  Author: Jason Molenda <jason at molenda.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M lldb/unittests/Breakpoint/WatchpointAlgorithmsTests.cpp

  Log Message:
  -----------
  Skip two WatchpointAlgorithm tests for 32-bit lldb's

After iterating with the arm-ubuntu CI bot, I found the crash (a
std::bad_alloc exception being thrown) was caused by these two
entries when built on a 32-bit machine.  I probably have an assumption
about size_t being 64-bits in WatchpointAlgorithms and we have a
problem when it's actually 32-bits and we're dealing with a real
64-bit address.  All of the cases where the address can be represented
in the low 32-bits of the addr_t work correctly, so for now I'm
skipping these two unit tests when building lldb on a 32-bit host
until I can review that method and possibly switch to explicit
uin64_t's.
.


Compare: https://github.com/llvm/llvm-project/compare/b67ce7e34948...90e68086d8fd