[all-commits] [llvm/llvm-project] 23a0d7: [NFC] [clang] add test for merging of UsingShadowDecl

Matheus Izvekov via All-commits all-commits at lists.llvm.org
Wed Jan 31 21:55:17 PST 2024


  Branch: refs/heads/users/mizvekov/bug/clang-merge-usingshadowdecl
  Home:   https://github.com/llvm/llvm-project
  Commit: 23a0d731cfe8593c338fc8ad7920f7aa9270afaa
      https://github.com/llvm/llvm-project/commit/23a0d731cfe8593c338fc8ad7920f7aa9270afaa
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    A clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [NFC] [clang] add test for merging of UsingShadowDecl


  Commit: b44f1b2ee3d709c627c1679fe3a252ea564bdd3d
      https://github.com/llvm/llvm-project/commit/b44f1b2ee3d709c627c1679fe3a252ea564bdd3d
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/ASTContext.cpp
    M clang/test/Modules/cxx20-decls.cppm

  Log Message:
  -----------
  [clang] fix merging of UsingShadowDecl

Previously, when deciding if two UsingShadowDecls where mergeable,
we would incorrectly only look for both pointing to the exact redecla
ration, whereas the correct thing is to look for declarations to the
same entity.

This problem has existed as far back as 2013, introduced in commit
fd8634a09de71.

This problem could manifest itself as ODR check false positives
when importing modules.

Fixes: #ISSUE_TO_BE_CREATED


Compare: https://github.com/llvm/llvm-project/compare/23a0d731cfe8%5E...b44f1b2ee3d7


More information about the All-commits mailing list