[all-commits] [llvm/llvm-project] 72d4fc: Revert "[AMDGPU] Do not emit arch dependent macros...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jan 29 09:11:40 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 72d4fc1b4d5cfc4f7d50cc5cf1b315543c088f4d
      https://github.com/llvm/llvm-project/commit/72d4fc1b4d5cfc4f7d50cc5cf1b315543c088f4d
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/test/CodeGenOpenCL/builtins-amdgcn-wave64.cl
    M clang/test/Preprocessor/predefined-arch-macros.c

  Log Message:
  -----------
  Revert "[AMDGPU] Do not emit arch dependent macros with unspecified cpu (#79660)"

This reverts commit c9a6e993f7b349405b6c8f9244cd9cf0f56a6a81.

This breaks HIP code that incorrectly depended on GPU-specific macros to
be set. The code is totally wrong as using `__WAVEFRTONSIZE__` on the
host is absolutely meaningless, but it seems this entire corner of the
toolchain is fundmentally broken. Reverting for now to avoid breakages.




More information about the All-commits mailing list