[all-commits] [llvm/llvm-project] 23b233: [clangd] Fix isSpelledInSource crash on invalid Fi...

Andrew Schenk via All-commits all-commits at lists.llvm.org
Sat Jan 27 23:34:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23b233c8adad5b81e185e50d04356fab64c2f870
      https://github.com/llvm/llvm-project/commit/23b233c8adad5b81e185e50d04356fab64c2f870
  Author: Andrew Schenk <154034018+schenka0 at users.noreply.github.com>
  Date:   2024-01-28 (Sun, 28 Jan 2024)

  Changed paths:
    M clang-tools-extra/clangd/SourceCode.cpp
    M clang-tools-extra/clangd/unittests/SourceCodeTests.cpp

  Log Message:
  -----------
  [clangd] Fix isSpelledInSource crash on invalid FileID (#76668)

This fixes the crash reported in #76667 and adds an initial unit test
for isSpelledInSource().

Note that in that issue there was still some underlying corrupted AST,
but this at least makes isSpelledInSource() robust to it.

---------

Co-authored-by: Younan Zhang <zyn7109 at gmail.com>




More information about the All-commits mailing list