[all-commits] [llvm/llvm-project] 80bfac: [lldb] Fix progress reporting for SymbolLocatorDeb...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri Jan 26 15:18:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 80bfac4327b6fb94cb9bf44eeb0d032799b9d418
      https://github.com/llvm/llvm-project/commit/80bfac4327b6fb94cb9bf44eeb0d032799b9d418
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M lldb/source/Plugins/SymbolLocator/DebugSymbols/SymbolLocatorDebugSymbols.cpp

  Log Message:
  -----------
  [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (#79624)

This fixes two issues related to the DebugSymbols symbol locator:

1. Only the default symbol locator plugin reports progress. On Darwin,
which uses the DebugSymbols framework we need to report the same
progress form the corresponding SymbolLocator plugin.

2. Forceful dSYM lookups, for example when using `add-dsym`, use a
different code path that currently does not report progress, which is
confusing. Here the progress event can be more specific and specify its
downloading a symbol file rather than just locating it as we'll always
shell out to dsymForUUID or its equivalent.

rdar://121629777




More information about the All-commits mailing list