[all-commits] [llvm/llvm-project] 56da79: [lldb] [NFC] Remove unused WatchpointResource::Set...

Jason Molenda via All-commits all-commits at lists.llvm.org
Wed Jan 24 15:19:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56da7991ead442b7c0ef9ec47d625253ed6b926e
      https://github.com/llvm/llvm-project/commit/56da7991ead442b7c0ef9ec47d625253ed6b926e
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M lldb/include/lldb/Breakpoint/WatchpointResource.h
    M lldb/source/Breakpoint/WatchpointResource.cpp

  Log Message:
  -----------
  [lldb] [NFC] Remove unused WatchpointResource::SetID method (#79389)

I originally thought to try to guesstimate the hardware watchpoint index
number that a Resource was associated with, but gdb remote serial
protocol doesn't give us the hardware register index used so it was only
a guess. I changed my mind and simply use ever-incrementing ID numbers
for the WatchpointResources, but forgot to remove the SetID method.




More information about the All-commits mailing list