[all-commits] [llvm/llvm-project] 80fcc9: [mlir][AMDGPU] Actually update the default ABI ver...
Krzysztof Drewniak via All-commits
all-commits at lists.llvm.org
Tue Jan 23 10:16:30 PST 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 80fcc9247a166ca056f049fc4662417b2ae157ce
https://github.com/llvm/llvm-project/commit/80fcc9247a166ca056f049fc4662417b2ae157ce
Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M mlir/include/mlir/Dialect/GPU/Transforms/Passes.td
M mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
Log Message:
-----------
[mlir][AMDGPU] Actually update the default ABI version, add comments (#79185)
Much confusion occurred earlier today when updating the fallback `int
abi;` in addControlVariables() didn't do anything. THis was because that
that value is the fallback for if the ABI version fails to parse ...
which it always should, because it has a default value that comes from
multiple different places.
This commit updates all the places said default variable can come from,
namely:
1. The ROCDL target attribute definition
2. The ROCDL target attribute's builders
3. The rocdl-attach-target pass's default option values.
With this, the printf test is passing.
More information about the All-commits
mailing list