[all-commits] [llvm/llvm-project] 2cff46: [libc][NFC] use builder pattern for ErrnoSetterMat...

Schrodinger ZHU Yifan via All-commits all-commits at lists.llvm.org
Tue Jan 23 07:43:36 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cff46f8c0aa88222aba776de094c650aa09a33d
      https://github.com/llvm/llvm-project/commit/2cff46f8c0aa88222aba776de094c650aa09a33d
  Author: Schrodinger ZHU Yifan <yifanzhu at rochester.edu>
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
    M libc/test/UnitTest/ErrnoSetterMatcher.h

  Log Message:
  -----------
  [libc][NFC] use builder pattern for ErrnoSetterMatcher (#79153)

ErrnoSetterMatcher::returns can be misleading as it does not initialize
the errno. This is made worse as later on there is a switch statement on
the errno comparator using __builtin_unreachable(). This patch make
ErrnoSetterMatcher::returns give back a builder that is nomially
different from ErrnoSetterMatcher.




More information about the All-commits mailing list