[all-commits] [llvm/llvm-project] 424b9c: [Coverage][clang] Ensure bitmap for ternary condit...

Alan Phipps via All-commits all-commits at lists.llvm.org
Mon Jan 22 14:33:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 424b9cf41abf376cc7a34640f5f451c91714f77b
      https://github.com/llvm/llvm-project/commit/424b9cf41abf376cc7a34640f5f451c91714f77b
  Author: Alan Phipps <a-phipps at ti.com>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M clang/lib/CodeGen/CGExprScalar.cpp
    A clang/test/Profile/c-mcdc-logicalop-ternary.c

  Log Message:
  -----------
  [Coverage][clang] Ensure bitmap for ternary condition is updated before visiting children (#78814)

This is a fix for MC/DC issue https://github.com/llvm/llvm-project/issues/78453 in which a ConditionalOperator that evaluates a complex condition was incorrectly updating its global bitmap after visiting its LHS and RHS children. This
was wrong because if the LHS or RHS also evaluate a complex condition, the MCDC temporary bitmap value will get corrupted. The fix is to ensure that the bitmap is updated prior to visiting the LHS and RHS.




More information about the All-commits mailing list