[all-commits] [llvm/llvm-project] 4e64ed: [X86] Update X86::getConstantFromPool to take base...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Mon Jan 22 07:41:05 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e64ed97804ab4146d9cc24db16a624a265aa690
      https://github.com/llvm/llvm-project/commit/4e64ed97804ab4146d9cc24db16a624a265aa690
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86FixupVectorConstants.cpp
    M llvm/lib/Target/X86/X86InstrInfo.cpp
    M llvm/lib/Target/X86/X86InstrInfo.h
    M llvm/lib/Target/X86/X86MCInstLower.cpp

  Log Message:
  -----------
  [X86] Update X86::getConstantFromPool to take base OperandNo instead of Displacement MachineOperand

This allows us to check the entire constant address calculation, and ensure we're not performing any runtime address math into the constant pool (noticed in an upcoming patch).


  Commit: 74ab7958bdda4d10b082129151f434176f99320e
      https://github.com/llvm/llvm-project/commit/74ab7958bdda4d10b082129151f434176f99320e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86MCInstLower.cpp
    M llvm/test/CodeGen/X86/combine-concatvectors.ll
    M llvm/test/CodeGen/X86/nontemporal-4.ll
    M llvm/test/CodeGen/X86/pr13577.ll
    M llvm/test/CodeGen/X86/ret-mmx.ll

  Log Message:
  -----------
  [X86] printZeroUpperMove - add support for constant vectors.

Allows cases where movss/movsd etc. are loading constant (ConstantDataSequential) sub-vectors, ensuring we pad with the correct number of zero upper elements by making repeated printConstant calls to print zeroes in a matching int/fp format.


Compare: https://github.com/llvm/llvm-project/compare/8c1b7fba1fbe...74ab7958bdda


More information about the All-commits mailing list